Mr. S Leather makes a fantastic leather jockstrap. Very comfortable, soft supple leather, and a contoured pouch to really cup and and accentuate your goods. I wore it last night all night under my kilt and it was comfortable and sexy.
https://www.mr-s-leather.com/traditional-leather-jockstrap